[CFI] Detail view dropdown by DylanDylann · Pull Request #106208 · Expensify/App

DylanDylann · 2026-11-06T11:13:43Z

Explanation of Change

Fixed Issues

$ #105904
PROPOSAL:

Tests

Same as QA steps

Verify that no errors appear in the JS console

Offline tests

QA Steps

Precondition: a Control workspace with categories, tags, taxes and attendee tracking enabled, and an expense on an open report.

Open the expense on a wide screen. Verify a "Details" heading, bordered fields like the create expense form, and a "Comments" heading above the thread once it has a comment.
Change the amount, description, merchant and tax amount, clicking outside each. Verify each saves. Pick a new currency and date, and verify they save at once.
Type (none) as the merchant, then a tax amount above what the rate allows. Verify each shows an error and doesn't save.
Click Category, Tag, Tax rate, Attendees and Report. Verify each list opens attached to the field (a bottom sheet on narrow screens) and a pick saves.
Open an expense on a paid report. Verify amount, merchant and date are locked, and on web hovering one offers to copy it.
Create a new expense. Verify the create form works as before.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2026-11-09.at.17.00.40.mov

Android: mWeb Chrome

Screen.Recording.2026-11-09.at.16.54.13.mov

iOS: Native

Screen.Recording.2026-11-09.at.16.53.17.mov

iOS: mWeb Safari

Screen.Recording.2026-11-09.at.16.48.18.mov

MacOS: Chrome / Safari

Screen.Recording.2026-11-09.at.16.45.27.mov

melvin-bot · 2026-11-06T11:13:51Z

@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector · 2026-11-06T11:14:00Z

Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	❌ Failed 2026-11-09T09:33:09.587708Z We couldn’t complete this review. Comment `@codex review` to try again.	`a438559`	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

codecov · 2026-11-06T11:17:59Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/CONST/SENTRY_LABEL.ts	`100.00% <ø> (ø)`
...AmountActionButtons/AmountCurrencyPickerButton.tsx	`94.44% <100.00%> (+1.11%)`	⬆️
...nents/AmountActionButtons/AmountSignFlipButton.tsx	`100.00% <100.00%> (ø)`
src/components/MenuItem/layout/MenuItemContent.tsx	`100.00% <100.00%> (ø)`
...eyRequestConfirmationList/sections/AmountField.tsx	`86.59% <ø> (-0.19%)`	⬇️
...onfirmationList/sections/AttendeeFieldDropdown.tsx	`100.00% <100.00%> (ø)`
...uestConfirmationList/sections/DescriptionField.tsx	`90.90% <100.00%> (ø)`
...questConfirmationList/sections/ExpenseFieldRow.tsx	`100.00% <100.00%> (ø)`
src/components/ReceiptAudit.tsx	`70.96% <100.00%> (+3.22%)`	⬆️
...rc/components/ReportActionItem/MoneyReportView.tsx	`95.77% <100.00%> (+0.39%)`	⬆️
... and 33 more
... and 8 files with indirect coverage changes

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: df224ebf73

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

… improving mirrored input behavior

…and improve dropdown functionality

ikevin127 · 2026-11-09T23:55:44Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If the PR adds or modifies the UI:
- I asked an AI agent to review the changes for accessibility issues and addressed its findings.
- I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
- I verified all new/changed elements have meaningful accessible names and roles.
- I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Screen.Recording.2026-11-09.at.18.17.26.mov

trjExpensify · 2026-11-10T00:40:21Z

@DylanDylann can you fix the conflicts and then I'll run a build?

ikevin127

Request changes (non-blockers that should still be addressed).

…teParams` hook for managing transaction updates and violations

github-actions · 2026-11-10T09:12:33Z

🚧 shawnborton has triggered a test Expensify/App build. You can view the workflow run here.

shawnborton · 2026-11-10T11:02:47Z

Can you check my prototype for all of my following comments? Just to have as a reference point. I will start leaving comments now :)

Let's get rid of the empty state peeking through at the top here - it's no longer needed:

shawnborton · 2026-11-10T11:28:55Z

Check for the correct padding/spacing values of the divider + label pattern:

From the proto:

… of NumberWithSymbolForm, enhancing input handling and structure.

… support for borderless styles, improving visual integration within forms. Update tests to verify new styling behavior and ensure proper ref handling for currency buttons.

DylanDylann · 2026-11-11T10:26:49Z

@shawnborton Can you review again on a new adhoc build?

DylanDylann · 2026-11-11T10:28:46Z

The failed check on main

github-actions · 2026-11-11T10:45:35Z

🚧 shawnborton has triggered a test Expensify/App build. You can view the workflow run here.

shawnborton · 2026-11-11T18:56:45Z

On the receipt side, the top padding is only 12px:

On the details side, it's 16px:

From the proto, it should be 16px for both:

shawnborton · 2026-11-11T18:59:31Z

Also it seems like read-only inputs are 54px tall:

When they should be 52px, like the inputs:

shawnborton · 2026-11-11T19:00:02Z

Select menus are also too big, they should be 52px as well but are 54px:

shawnborton · 2026-11-11T19:01:19Z

Otherwise feeling pretty good, let's fix those quickly but also continue our final review since this is a big one.

ikevin127 · 2026-11-11T23:56:38Z

Awaiting on final design nits to be fixed before taking another look. Please tag me once it's my turn at this 🙌

DylanDylann · 2026-11-12T06:57:28Z

Awaiting on final design nits to be fixed before taking another look. Please tag me once it's my turn at this 🙌

@ikevin127 It’s just minor styling. I don’t think it blocks your review. It's better if you can start your next review

DylanDylann · 2026-11-12T07:13:55Z

@shawnborton Ready for your next review

github-actions · 2026-11-12T08:54:03Z

🚧 shawnborton has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-11-12T08:59:34Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #106208 with the pinned Mobile-Expensify submodule.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-d405b516-5983a8a-007df497f18b11a524341cb983dd0aee6438bb4a/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-d405b516-5983a8a-9979f11f667eda10dfcc8729f3d74bf27d268c41/index.html

Web 🕸️
https://106208.adhoc.expensify.com

👀 View the workflow run that generated this build 👀

shawnborton · 2026-11-12T09:58:42Z

Still seeing read-only inputs as 54px tall:

shawnborton · 2026-11-12T09:59:07Z

Other nit was fixed though. @ikevin127 I say start your review since this is a big one.

ikevin127

Request changes (non-blockers that should still be addressed).

@DylanDylann, everything from my last round is fixed. The new AmountFormField inputs don't save on Enter anymore ⚠️

trjExpensify · 2026-11-13T01:56:19Z

@DylanDylann are you going to be able to fix these conflicts and address the comments today? Would love to get it merged if we can. 👍

…ldRow to apply zero gap style for better layout consistency

DylanDylann · 2026-11-13T07:22:11Z

@shawnborton Fixed

shawnborton · 2026-11-13T08:41:00Z

Thanks! Continue with final review please @ikevin127 we're excited for this one.

saved-expense-text-inputs

df224eb

DylanDylann requested review from a team as code owners November 6, 2026 11:13

melvin-bot Bot assigned DylanDylann Nov 6, 2026

melvin-bot Bot requested review from ikevin127 and removed request for a team November 6, 2026 11:13

melvin-bot Bot requested review from trjExpensify and removed request for a team November 6, 2026 11:13

chatgpt-codex-connector Bot reviewed Nov 6, 2026

View reviewed changes

DylanDylann changed the title ~~[CFI] Detail view dropdown- #105603~~ [CFI] Detail view dropdown Nov 6, 2026

DylanDylann marked this pull request as draft November 6, 2026 11:43

DylanDylann added 3 commits November 9, 2026 15:46

saved-expense-text-inputs

d276574

Merge branch 'main' into dylann/105904-saved-expense-text-inputs

73af02d

enhance merchant input handling by stripping invisible characters and…

a438559

… improving mirrored input behavior

DylanDylann marked this pull request as ready for review November 9, 2026 09:15

update attendee handling in MoneyRequest components to use new hooks …

0733cb7

…and improve dropdown functionality

ikevin127 suggested changes Nov 10, 2026

View reviewed changes

DylanDylann added 3 commits November 10, 2026 13:29

Merge branch 'main' into dylann/105904-saved-expense-text-inputs

f960425

Refactor Money Request components to utilize new `useMoneyRequestUpda…

ea6b8b0

…teParams` hook for managing transaction updates and violations

address comments

f19eb0a

DylanDylann requested a review from ikevin127 November 10, 2026 06:58

This comment has been minimized.

Sign in to view

DylanDylann added 2 commits November 11, 2026 17:06

Refactor TaxAmountInputField to use AmountFormField component instead…

6d5c7f6

… of NumberWithSymbolForm, enhancing input handling and structure.

Enhance AmountActionButtons and AmountInputField components by adding…

0379e58

… support for borderless styles, improving visual integration within forms. Update tests to verify new styling behavior and ensure proper ref handling for currency buttons.

This comment has been minimized.

Sign in to view

DylanDylann added 2 commits November 12, 2026 13:48

Merge branch 'main' into dylann/105904-saved-expense-text-inputs

491612a

update padding

c059c72

DylanDylann requested a review from a team as a code owner November 12, 2026 06:53

Fix selected tax rate calculation in MoneyRequestView component

d405b51

ikevin127 suggested changes Nov 12, 2026

View reviewed changes

Comment thread src/components/ReportActionItem/MoneyRequestViewFields/AmountInputField.tsx Resolved

Comment thread tests/ui/MoneyRequestViewTest.tsx Resolved

DylanDylann added 4 commits November 13, 2026 13:38

Enhance MenuItemContent to accept custom styles and update ExpenseFie…

c8d7453

…ldRow to apply zero gap style for better layout consistency

Merge branch 'main' into dylann/105904-saved-expense-text-inputs

fe8de32

merge main

ec532f0

address comments

c417d65

DylanDylann requested a review from ikevin127 November 13, 2026 07:15

Conversation

DylanDylann commented Nov 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Nov 6, 2026

Uh oh!

chatgpt-codex-connector Bot commented Nov 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Nov 6, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ikevin127 commented Nov 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

trjExpensify commented Nov 10, 2026

Uh oh!

ikevin127 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Nov 10, 2026

Uh oh!

This comment has been minimized.

shawnborton commented Nov 10, 2026

Uh oh!

shawnborton commented Nov 10, 2026

Uh oh!

DylanDylann commented Nov 11, 2026

Uh oh!

DylanDylann commented Nov 11, 2026

Uh oh!

github-actions Bot commented Nov 11, 2026

Uh oh!

This comment has been minimized.

shawnborton commented Nov 11, 2026

Uh oh!

shawnborton commented Nov 11, 2026

Uh oh!

shawnborton commented Nov 11, 2026

Uh oh!

shawnborton commented Nov 11, 2026

Uh oh!

ikevin127 commented Nov 11, 2026

Uh oh!

DylanDylann commented Nov 12, 2026

Uh oh!

DylanDylann commented Nov 12, 2026

Uh oh!

github-actions Bot commented Nov 12, 2026

Uh oh!

DylanDylann commented Nov 6, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Nov 6, 2026 •

edited

Loading

codecov Bot commented Nov 6, 2026 •

edited by github-actions Bot

Loading

ikevin127 commented Nov 9, 2026 •

edited

Loading